public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd: fix HDMI signal type for EDID overrides
Date: Mon, 16 Mar 2026 11:48:51 +1000	[thread overview]
Message-ID: <review-patch2-20260315223307.45807-3-johanneswueller@gmail.com> (raw)
In-Reply-To: <20260315223307.45807-3-johanneswueller@gmail.com>

Patch Review

**Potential problem with `populate_hdmi_info_from_connector()`:** In `dm_helpers_parse_edid_caps()`, when the code forces `edid_caps->edid_hdmi = true` due to the override, it then calls:
```c
if (edid_caps->edid_hdmi)
    populate_hdmi_info_from_connector(&connector->display_info.hdmi, edid_caps);
```
But `connector->display_info.hdmi` was populated from the *overridden* EDID (which lacks HDMI VSDB). This means the HDMI info structure will contain zeros/defaults, which could lead to issues downstream (e.g. missing audio capabilities, incorrect infoframe data). The patch should document this limitation or handle it.

**Duplicated logic:** The connector-type check `(connector->connector_type == DRM_MODE_CONNECTOR_HDMIA || connector->connector_type == DRM_MODE_CONNECTOR_HDMIB)` appears in two places. A small helper like `drm_connector_is_hdmi_type()` would reduce duplication, though this is minor.

**Signal type for HDMIB:** Setting `SIGNAL_TYPE_HDMI_TYPE_A` for `DRM_MODE_CONNECTOR_HDMIB` connectors is technically incorrect - HDMI Type B uses a different physical connector. In practice HDMIB is essentially unused, so this is unlikely to cause real issues, but it's worth noting.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-16  1:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-15 22:33 [PATCH 0/4] drm/amd: fix HDMI output with non-HDMI EDID overrides Johannes Wüller
2026-03-15 22:33 ` [PATCH 1/4] drm: add edid_overridden flag to drm_connector Johannes Wüller
2026-03-16  1:48   ` Claude review: " Claude Code Review Bot
2026-03-15 22:33 ` [PATCH 2/4] drm/amd: fix HDMI signal type for EDID overrides Johannes Wüller
2026-03-16  1:48   ` Claude Code Review Bot [this message]
2026-03-15 22:33 ` [PATCH 3/4] drm/amd: treat max_tmds_clock==0 as unconstrained Johannes Wüller
2026-03-16  1:48   ` Claude review: " Claude Code Review Bot
2026-03-15 22:33 ` [PATCH 4/4] drm/amd: fix force_yuv420/422_output being ignored Johannes Wüller
2026-03-16  1:48   ` Claude review: " Claude Code Review Bot
2026-03-16  1:48 ` Claude review: drm/amd: fix HDMI output with non-HDMI EDID overrides Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260315223307.45807-3-johanneswueller@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox