From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd: fix HDMI signal type for EDID overrides Date: Mon, 16 Mar 2026 11:48:51 +1000 Message-ID: In-Reply-To: <20260315223307.45807-3-johanneswueller@gmail.com> References: <20260315223307.45807-1-johanneswueller@gmail.com> <20260315223307.45807-3-johanneswueller@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Potential problem with `populate_hdmi_info_from_connector()`:** In `dm_helpers_parse_edid_caps()`, when the code forces `edid_caps->edid_hdmi = true` due to the override, it then calls: ```c if (edid_caps->edid_hdmi) populate_hdmi_info_from_connector(&connector->display_info.hdmi, edid_caps); ``` But `connector->display_info.hdmi` was populated from the *overridden* EDID (which lacks HDMI VSDB). This means the HDMI info structure will contain zeros/defaults, which could lead to issues downstream (e.g. missing audio capabilities, incorrect infoframe data). The patch should document this limitation or handle it. **Duplicated logic:** The connector-type check `(connector->connector_type == DRM_MODE_CONNECTOR_HDMIA || connector->connector_type == DRM_MODE_CONNECTOR_HDMIB)` appears in two places. A small helper like `drm_connector_is_hdmi_type()` would reduce duplication, though this is minor. **Signal type for HDMIB:** Setting `SIGNAL_TYPE_HDMI_TYPE_A` for `DRM_MODE_CONNECTOR_HDMIB` connectors is technically incorrect - HDMI Type B uses a different physical connector. In practice HDMIB is essentially unused, so this is unlikely to cause real issues, but it's worth noting. --- Generated by Claude Code Patch Reviewer