public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/dsi: Add support for RGB101010 pixel format
Date: Sun, 22 Mar 2026 04:52:40 +1000	[thread overview]
Message-ID: <review-patch2-20260318-dsi-rgb101010-support-v2-2-698b7612eaeb@pm.me> (raw)
In-Reply-To: <20260318-dsi-rgb101010-support-v2-2-698b7612eaeb@pm.me>

Patch Review

**`has_rgb30` flag approach:** Using a per-config boolean flag is a reasonable approach given the version-guarding requirement. The check in `dsi_host_attach()` is clean:

```c
+	if (dsi->format == MIPI_DSI_FMT_RGB101010 &&
+	    !msm_host->cfg_hnd->cfg->has_rgb30) {
+		DRM_DEV_ERROR(&msm_host->pdev->dev,
+			      "RGB101010 not supported on this DSI controller\n");
+		return -EINVAL;
+	}
```

**Missing configs:** The patch sets `has_rgb30 = true` for msm8998, sdm660, sdm845, sm8550, sm8650, kaanapali, sc7280, and sa8775p. However, the cover letter says this is guarded behind `MSM_DSI_6G_VER >= V2.1.0`, yet `msm8998_dsi_cfg` and `sdm660_dsi_cfg` are V1.x era configs. Are these actually V2.1.0+? If the hardware truly requires V2.1.0+, then marking msm8998 (which is 6G v1.x based) as `has_rgb30 = true` may be incorrect. The commit message and the actual flag settings should be reconciled.

**Register XML changes are correct:** Extending `VID_CFG0.DST_FORMAT` from bits [4:5] to [4:6] and adding `VID_DST_FORMAT_RGB101010 = 4` and `CMD_DST_FORMAT_RGB101010 = 9` looks appropriate. The comment `<!-- high was 5 before DSI 6G 2.1.0 -->` is a helpful annotation.

**Format mapping additions** in `dsi_get_vid_fmt()` and `dsi_get_cmd_fmt()` are straightforward and correct.

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-21 18:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19  3:59 [PATCH v2 0/3] drm/msm: add RGB101010 pixel format and fix 10-bit DSC timing Alexander Koskovich
2026-03-19  4:00 ` [PATCH v2 1/3] drm/mipi-dsi: add RGB101010 pixel format Alexander Koskovich
2026-03-21 18:52   ` Claude review: " Claude Code Review Bot
2026-03-19  4:00 ` [PATCH v2 2/3] drm/msm/dsi: Add support for " Alexander Koskovich
2026-03-19  4:21   ` Dmitry Baryshkov
2026-03-19  9:10   ` Konrad Dybcio
2026-03-19  9:25     ` Alexander Koskovich
2026-03-19  9:39       ` Konrad Dybcio
2026-03-21 18:52   ` Claude Code Review Bot [this message]
2026-03-19  4:00 ` [PATCH v2 3/3] drm/msm/dpu: fix video mode DSC INTF timing width for non 8 bit panels Alexander Koskovich
2026-03-19  8:34   ` Neil Armstrong
2026-03-19  8:48     ` Alexander Koskovich
2026-03-19 10:33       ` Neil Armstrong
2026-03-19 10:04     ` Konrad Dybcio
2026-03-21 18:52   ` Claude review: " Claude Code Review Bot
2026-03-21 18:52 ` Claude review: drm/msm: add RGB101010 pixel format and fix 10-bit DSC timing Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-19 11:57 [PATCH v3 0/4] " Alexander Koskovich
2026-03-19 11:57 ` [PATCH v3 3/4] drm/msm/dsi: Add support for RGB101010 pixel format Alexander Koskovich
2026-03-21 18:21   ` Claude review: " Claude Code Review Bot
2026-03-21  7:52 [PATCH v4 0/5] drm/msm: add RGB101010 pixel format and fix 10-bit DSC timing Alexander Koskovich
2026-03-21  7:52 ` [PATCH v4 5/5] drm/msm/dsi: Add support for RGB101010 pixel format Alexander Koskovich
2026-03-21 17:12   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260318-dsi-rgb101010-support-v2-2-698b7612eaeb@pm.me \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox