From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dsi: add DSI version >= comparison helper Date: Sun, 22 Mar 2026 04:21:56 +1000 Message-ID: In-Reply-To: <20260319-dsi-rgb101010-support-v3-2-85b99df2d090@pm.me> References: <20260319-dsi-rgb101010-support-v3-0-85b99df2d090@pm.me> <20260319-dsi-rgb101010-support-v3-2-85b99df2d090@pm.me> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Minor issue with the helper semantics:** ```c +static bool msm_dsi_host_version_ge(struct msm_dsi_host *msm_host, + u32 major, u32 minor) +{ + return msm_host->cfg_hnd->major =3D=3D major && + msm_host->cfg_hnd->minor >=3D minor; +} ``` This function checks `major =3D=3D major && minor >=3D minor`, which means = it is NOT a true "greater than or equal" across major versions =E2=80=94 it= only works when the major version matches exactly. If a future DSI control= ler had `major =3D 0x04`, this would return `false` even though that versio= n is strictly greater than any `0x03` version. For the current use (all 6G controllers share `MSM_DSI_VER_MAJOR_6G =3D=3D = 0x03`), this works fine, but the name `_ge` is slightly misleading. The cov= er letter mentions "msm_dsi_host_version_is_gt per Konrad" but the implemen= tation is `_ge` (greater-or-equal), which is what the code actually needs. = This inconsistency in naming between cover letter and code is minor. The refactoring of `msm_dsi_host_is_wide_bus_enabled` to use the new helper= is a clean simplification. --- Generated by Claude Code Patch Reviewer