From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/connector: hdmi: Add support for 'link bpc' property
Date: Sun, 22 Mar 2026 04:19:40 +1000 [thread overview]
Message-ID: <review-patch2-20260319-link-bpc-v5-2-5306cd04a708@collabora.com> (raw)
In-Reply-To: <20260319-link-bpc-v5-2-5306cd04a708@collabora.com>
Patch Review
This patch is clean and straightforward.
**Setting link_bpc during atomic check:**
```c
new_conn_state->link_bpc = new_conn_state->hdmi.output_bpc;
```
This sets `link_bpc` from `output_bpc` during `drm_atomic_helper_connector_hdmi_check()`. The `output_bpc` is computed during check and represents the negotiated bpc after bandwidth constraints. This is the correct place to set it for HDMI connectors using the helper framework.
**Automatic attachment in drmm_connector_hdmi_init:**
```c
ret = drm_connector_attach_link_bpc_property(connector, max_bpc);
if (ret)
return ret;
```
Return value is properly checked here. Good.
**One consideration:** When the CRTC is disabled (no `new_conn_state->crtc`), `link_bpc` is not explicitly set to 0 or any sentinel value. The `else` branch of the check doesn't touch `link_bpc`, so it retains whatever value was in the old state (or the default 0). This means that on disconnect, the property won't be updated (the commit_tail check compares old vs new, and if they're the same, it won't fire). This seems acceptable but could be documented.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-21 18:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 12:28 [PATCH v5 0/3] Add "link bpc" DRM property Nicolas Frattaroli
2026-03-19 12:28 ` [PATCH v5 1/3] drm/connector: Add a 'link bpc' property Nicolas Frattaroli
2026-03-21 18:19 ` Claude review: " Claude Code Review Bot
2026-03-19 12:28 ` [PATCH v5 2/3] drm/connector: hdmi: Add support for " Nicolas Frattaroli
2026-03-21 18:19 ` Claude Code Review Bot [this message]
2026-03-19 12:28 ` [PATCH v5 3/3] drm/amd/display: " Nicolas Frattaroli
2026-03-21 18:19 ` Claude review: " Claude Code Review Bot
2026-03-20 14:32 ` [PATCH v5 0/3] Add "link bpc" DRM property Michel Dänzer
2026-03-20 18:02 ` Nicolas Frattaroli
2026-03-21 2:33 ` Mario Kleiner
2026-03-21 18:19 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260319-link-bpc-v5-2-5306cd04a708@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox