From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/connector: hdmi: Add support for 'link bpc' property Date: Sun, 22 Mar 2026 04:19:40 +1000 Message-ID: In-Reply-To: <20260319-link-bpc-v5-2-5306cd04a708@collabora.com> References: <20260319-link-bpc-v5-0-5306cd04a708@collabora.com> <20260319-link-bpc-v5-2-5306cd04a708@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This patch is clean and straightforward. **Setting link_bpc during atomic check:** ```c new_conn_state->link_bpc = new_conn_state->hdmi.output_bpc; ``` This sets `link_bpc` from `output_bpc` during `drm_atomic_helper_connector_hdmi_check()`. The `output_bpc` is computed during check and represents the negotiated bpc after bandwidth constraints. This is the correct place to set it for HDMI connectors using the helper framework. **Automatic attachment in drmm_connector_hdmi_init:** ```c ret = drm_connector_attach_link_bpc_property(connector, max_bpc); if (ret) return ret; ``` Return value is properly checked here. Good. **One consideration:** When the CRTC is disabled (no `new_conn_state->crtc`), `link_bpc` is not explicitly set to 0 or any sentinel value. The `else` branch of the check doesn't touch `link_bpc`, so it retains whatever value was in the old state (or the default 0). This means that on disconnect, the property won't be updated (the commit_tail check compares old vs new, and if they're the same, it won't fire). This seems acceptable but could be documented. --- Generated by Claude Code Patch Reviewer