public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: bus: mhi: Move sahara protocol driver under drivers/bus/mhi
Date: Sun, 22 Mar 2026 04:44:33 +1000	[thread overview]
Message-ID: <review-patch2-20260319-sahara_protocol_new_v2-v4-2-47ad79308762@oss.qualcomm.com> (raw)
In-Reply-To: <20260319-sahara_protocol_new_v2-v4-2-47ad79308762@oss.qualcomm.com>

Patch Review

Relocates the Sahara driver to `drivers/bus/mhi/sahara/` and makes it a standalone module.

**Issues:**

- **Bug: `qaic_init()` error handling is broken.** The goto labels are swapped after removing `sahara_register()`:
  ```c
  ret = pci_register_driver(&qaic_pci_driver);
  if (ret) {
      pr_debug("qaic: pci_register_driver failed %d\n", ret);
      goto free_pci;  // BUG: calls pci_unregister_driver on never-registered driver
  }

  ret = mhi_driver_register(&qaic_mhi_driver);
  if (ret) {
      pr_debug("qaic: mhi_driver_register failed %d\n", ret);
      goto free_mhi;  // BUG: calls mhi_driver_unregister on never-registered driver
  }
  ```
  Correct behavior: `pci_register_driver` failure should `return ret` directly; `mhi_driver_register` failure should `goto free_pci`.

- **SPDX license changed** from `GPL-2.0-only` to `GPL-2.0` and copyright changed from "2024 Qualcomm Innovation Center" to "2018-2020, The Linux Foundation". This needs justification in the commit message.

- **Kconfig forces `FW_LOADER_COMPRESS_XZ` and `FW_LOADER_COMPRESS_ZSTD`** unconditionally. This imposes decompression dependencies on all users. Should this be optional?

- **Dead declarations in `include/linux/sahara.h`**: `sahara_register()`/`sahara_unregister()` are now wrapped in `module_init`/`module_exit` but still declared in the public header. QAIC no longer calls them.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-21 18:44 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19  6:31 [PATCH v4 0/9] Qualcomm Sahara protocol enhancements Kishore Batta
2026-03-19  6:31 ` [PATCH v4 1/9] Add documentation for Sahara protocol Kishore Batta
2026-03-21 18:44   ` Claude review: " Claude Code Review Bot
2026-03-19  6:31 ` [PATCH v4 2/9] bus: mhi: Move sahara protocol driver under drivers/bus/mhi Kishore Batta
2026-03-21 18:44   ` Claude Code Review Bot [this message]
2026-03-19  6:31 ` [PATCH v4 3/9] bus: mhi: Match devices exposing the protocol on the SAHARA channel Kishore Batta
2026-03-21 18:44   ` Claude review: " Claude Code Review Bot
2026-03-19  6:31 ` [PATCH v4 4/9] bus: mhi: Centralize firmware image table selection at probe time Kishore Batta
2026-03-21 18:44   ` Claude review: " Claude Code Review Bot
2026-03-19  6:31 ` [PATCH v4 5/9] bus: mhi: Add QDU100 variant and image_id firmware fallback Kishore Batta
2026-03-21 18:44   ` Claude review: " Claude Code Review Bot
2026-03-19  6:31 ` [PATCH v4 6/9] bus: mhi: Load DDR training data using per-device serial number Kishore Batta
2026-03-21 18:44   ` Claude review: " Claude Code Review Bot
2026-03-19  6:31 ` [PATCH v4 7/9] bus: mhi: Capture DDR training data using command mode Kishore Batta
2026-03-21 18:44   ` Claude review: " Claude Code Review Bot
2026-03-19  6:31 ` [PATCH v4 8/9] bus: mhi: Expose DDR training data via controller sysfs Kishore Batta
2026-03-21 18:44   ` Claude review: " Claude Code Review Bot
2026-03-19  6:31 ` [PATCH v4 9/9] Documentation: ABI: Add sysfs ABI documentation for DDR training data Kishore Batta
2026-03-21 18:44   ` Claude review: " Claude Code Review Bot
2026-03-21 18:44 ` Claude review: Qualcomm Sahara protocol enhancements Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-10  7:21 [PATCH v3 0/9] " Kishore Batta
2026-03-10  7:21 ` [PATCH v3 2/9] bus: mhi: Move sahara protocol driver under drivers/bus/mhi Kishore Batta
2026-03-11  3:35   ` Claude review: " Claude Code Review Bot
2026-03-07 11:41 [PATCH v2 0/9] Qualcomm Sahara protocol enhancements Kishore Batta
2026-03-07 11:41 ` [PATCH v2 2/9] bus: mhi: Move sahara protocol driver under drivers/bus/mhi Kishore Batta
2026-03-08 22:09   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260319-sahara_protocol_new_v2-v4-2-47ad79308762@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox