From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/mipi-dbi: Support custom pipelines with drm_mipi_dbi_dev_init() Date: Sun, 22 Mar 2026 04:15:33 +1000 Message-ID: In-Reply-To: <20260319160110.109610-3-tzimmermann@suse.de> References: <20260319160110.109610-1-tzimmermann@suse.de> <20260319160110.109610-3-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean extraction of device initialization from pipeline setup. The new `drm_mipi_dbi_dev_init()` properly handles tx_buf allocation, mode rotation, pixel format, and write_memory_bpw setup. The change from `DRM_ERROR` / `DRM_DEBUG_KMS` to `drm_err` / `drm_dbg` is a nice modernization done as part of the refactoring. Passing `tx_buf_size = 0` to auto-calculate the buffer size is a good API design that simplifies callers. No issues found. --- Generated by Claude Code Patch Reviewer