From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: renesas: rzg2l_mipi_dsi: Fix assert of CMN_RSTB signal
Date: Sun, 22 Mar 2026 04:12:40 +1000 [thread overview]
Message-ID: <review-patch2-20260319164833.409126-3-biju.das.jz@bp.renesas.com> (raw)
In-Reply-To: <20260319164833.409126-3-biju.das.jz@bp.renesas.com>
Patch Review
Moves `reset_control_assert(dsi->rstc)` from `rzg2l_mipi_dsi_dphy_exit()` to `rzg2l_mipi_dsi_stop()`, placing it **before** the `dphy_exit()` call.
```c
static void rzg2l_mipi_dsi_stop(struct rzg2l_mipi_dsi *dsi)
{
+ reset_control_assert(dsi->rstc);
dsi->info->dphy_exit(dsi);
pm_runtime_put(dsi->dev);
}
```
**Question on ordering:** The commit message says "placing it before the dphy_exit() call." The original code had the assert at the *end* of `dphy_exit()` — so it was after the PHY power-down sequence. Now it's *before* the PHY power-down. Is asserting CMN_RSTB before powering down the PHY (clearing EN_LDO1200, EN_BGR) the correct hardware sequence? The commit message doesn't explain *why* the assert must come before `dphy_exit()` rather than after. The hardware manual section cited is about the reset sequence, so if the manual says assert first then power down, this is fine, but it would be good to have that clarified in the commit message.
**Fixes tags:** The two `Fixes:` tags reference commits that add OF data support and lanes checking. These seem tangential — the original placement of `reset_control_assert()` in `dphy_exit()` dates back to the initial driver commit, not to these fixes-referenced commits. The `Fixes:` tags should point to the commit that originally placed the assert in the wrong location.
**RZ/V2H note:** The commit message says "Since this reset signal is optional for RZ/V2H, the call is a no-op on that SoC." This is correct — `dsi->rstc` is obtained via `devm_reset_control_get_optional_exclusive()`, so it will be NULL when not present, and `reset_control_assert(NULL)` is a no-op.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-21 18:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 16:48 [PATCH v2 0/4] Improvements on RZ/G2L MIPI DSI driver Biju
2026-03-19 16:48 ` [PATCH v2 1/4] drm: renesas: rzg2l_mipi_dsi: Move rzg2l_mipi_dsi_set_display_timing() Biju
2026-03-21 18:12 ` Claude review: " Claude Code Review Bot
2026-03-19 16:48 ` [PATCH v2 2/4] drm: renesas: rzg2l_mipi_dsi: Fix assert of CMN_RSTB signal Biju
2026-03-21 18:12 ` Claude Code Review Bot [this message]
2026-03-19 16:48 ` [PATCH v2 3/4] drm: renesas: rzg2l_mipi_dsi: Fix deassert " Biju
2026-03-21 18:12 ` Claude review: " Claude Code Review Bot
2026-03-19 16:48 ` [PATCH v2 4/4] drm: renesas: rzg2l_mipi_dsi: Increase reset deassertion delay to 1 msec Biju
2026-03-21 18:12 ` Claude review: " Claude Code Review Bot
2026-03-21 18:12 ` Claude review: Improvements on RZ/G2L MIPI DSI driver Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260319164833.409126-3-biju.das.jz@bp.renesas.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox