Claude review: drm/imagination: Add PVR_GPU_ID_FMT to format pvr_gpu_id

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Overall:** Straightforward and correct. Fixes a real (if minor) bug with format specifiers.

**Format macros are well-designed:**
```c
#define PVR_GPU_ID_FMT "%u.%u.%u.%u"
#define PVR_GPU_ID_FMT_ARGS(gpu_id) (gpu_id)->b, (gpu_id)->v, (gpu_id)->n, (gpu_id)->c
#define PVR_GPU_ID_FMT_ARGS_PACKED(gpu_id) \
	(u32)FIELD_GET(DRM_PVR_BVNC_B, gpu_id), (u32)FIELD_GET(DRM_PVR_BVNC_V, gpu_id), \
	(u32)FIELD_GET(DRM_PVR_BVNC_N, gpu_id), (u32)FIELD_GET(DRM_PVR_BVNC_C, gpu_id)
```
Using `%u` is correct since the struct fields are `u16`. The `(u32)` casts in the packed variant are appropriate because `FIELD_GET` returns `u64` and `%u` expects `unsigned int`.

**The pvr_fw.c simplification is a nice win:**
```c
drm_err(drm_dev, "FW built for incorrect GPU ID " PVR_GPU_ID_FMT " (expected " PVR_GPU_ID_FMT ")\n",
        PVR_GPU_ID_FMT_ARGS_PACKED(header->bvnc),
        PVR_GPU_ID_FMT_ARGS(&pvr_dev->gpu_id));
```
This eliminates the temporary `fw_gpu_id` variable and the intermediate `packed_bvnc_to_pvr_gpu_id()` call in the error path, which is cleaner.

**Minor observation:** `PVR_GPU_ID_FMT_ARGS` evaluates `gpu_id` four times. If someone passed an expression with side effects, it would be evaluated four times. This is a common pattern for such macros in the kernel and all current callers pass simple pointer expressions, so this is fine in practice.

**No issues found.** Reviewed-by worthy.

---
Generated by Claude Code Patch Reviewer