From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/mxsfb/lcdif: don't unnecessarily loop over ports Date: Sun, 22 Mar 2026 03:48:37 +1000 Message-ID: In-Reply-To: <20260320-drm-lcdif-dbanc-v1-2-479a04133e70@bootlin.com> References: <20260320-drm-lcdif-dbanc-v1-0-479a04133e70@bootlin.com> <20260320-drm-lcdif-dbanc-v1-2-479a04133e70@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This is a good simplification. Using `of_graph_get_remote_node(dev->of_node= , 0, -1)` to directly get port 0's remote is cleaner than iterating endpoin= ts. **Minor nit:** The commit message has typos: "thos" should be "those", and = "multipltle" should be "multiple". One observation: the original code used `devm_drm_of_get_bridge(dev, dev->o= f_node, 0, of_ep.id)` where `of_ep.id` was the endpoint id. The new code us= es `devm_drm_of_get_bridge(dev, dev->of_node, 0, -1)`. Since there's only o= ne port with one endpoint, this should be equivalent, but worth confirming = the `-1` semantics for `devm_drm_of_get_bridge` are "any endpoint" (which t= hey are =E2=80=94 it passes through to `of_graph_get_remote_node`). The `__free(device_node)` usage here is correct =E2=80=94 good, this was fi= xed from patch 1's bug. --- Generated by Claude Code Patch Reviewer