From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/atomic: Drop drm_private_state.obj assignment from create_state Date: Sun, 22 Mar 2026 03:32:25 +1000 Message-ID: In-Reply-To: <20260320-drm-mode-config-init-v2-2-c63f1134e76c@kernel.org> References: <20260320-drm-mode-config-init-v2-0-c63f1134e76c@kernel.org> <20260320-drm-mode-config-init-v2-2-c63f1134e76c@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Removes `obj->state = state` from `__drm_atomic_helper_private_obj_create_state()`. The commit message claims this is redundant because the only caller `drm_atomic_private_obj_init()` also sets it. However, looking at the current tree, `drm_atomic_private_obj_init()` has already been reworked (it now takes a `state` parameter and has conditional logic). The patch appears to be based on a prerequisite series (`20251008-drm-private-obj-reset-ae1e2741027a:v5`) that may have changed the function signature. This should be fine as long as the prerequisites are merged first, but worth verifying. The Fixes tag seems appropriate since the assignment was indeed a side effect that the `create_state` contract shouldn't have. --- Generated by Claude Code Patch Reviewer