From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: helpers: Add bindings/wrappers for dma_resv_lock
Date: Sun, 22 Mar 2026 03:35:23 +1000 [thread overview]
Message-ID: <review-patch2-20260320-gpuvm-rust-v5-2-76fd44f17a87@google.com> (raw)
In-Reply-To: <20260320-gpuvm-rust-v5-2-76fd44f17a87@google.com>
Patch Review
Straightforward C helper additions. Well-reviewed by multiple people.
**Minor:** The `dma_resv_lock` helper passes through `ctx` but the Rust side always calls it with `null_mut()`. The helper is fine as-is for general use, but worth noting the `null` usage in patch 3 is the deadlock concern mentioned above.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-21 17:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 16:08 [PATCH v5 0/6] Rust GPUVM immediate mode Alice Ryhl
2026-03-20 16:08 ` [PATCH v5 1/6] rust: drm: add base GPUVM immediate mode abstraction Alice Ryhl
2026-03-21 17:35 ` Claude review: " Claude Code Review Bot
2026-03-20 16:08 ` [PATCH v5 2/6] rust: helpers: Add bindings/wrappers for dma_resv_lock Alice Ryhl
2026-03-21 17:35 ` Claude Code Review Bot [this message]
2026-03-20 16:08 ` [PATCH v5 3/6] rust: gpuvm: add GpuVm::obtain() Alice Ryhl
2026-03-21 17:35 ` Claude review: " Claude Code Review Bot
2026-03-20 16:08 ` [PATCH v5 4/6] rust: gpuvm: add GpuVa struct Alice Ryhl
2026-03-21 17:35 ` Claude review: " Claude Code Review Bot
2026-03-20 16:08 ` [PATCH v5 5/6] rust: gpuvm: add GpuVmCore::sm_unmap() Alice Ryhl
2026-03-21 17:35 ` Claude review: " Claude Code Review Bot
2026-03-20 16:08 ` [PATCH v5 6/6] rust: gpuvm: add GpuVmCore::sm_map() Alice Ryhl
2026-03-21 17:35 ` Claude review: " Claude Code Review Bot
2026-03-21 17:35 ` Claude review: Rust GPUVM immediate mode Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260320-gpuvm-rust-v5-2-76fd44f17a87@google.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox