From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: rust: helpers: Add bindings/wrappers for dma_resv_lock Date: Sun, 22 Mar 2026 03:35:23 +1000 Message-ID: In-Reply-To: <20260320-gpuvm-rust-v5-2-76fd44f17a87@google.com> References: <20260320-gpuvm-rust-v5-0-76fd44f17a87@google.com> <20260320-gpuvm-rust-v5-2-76fd44f17a87@google.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Straightforward C helper additions. Well-reviewed by multiple people. **Minor:** The `dma_resv_lock` helper passes through `ctx` but the Rust side always calls it with `null_mut()`. The helper is fine as-is for general use, but worth noting the `null` usage in patch 3 is the deadlock concern mentioned above. --- Generated by Claude Code Patch Reviewer