Claude review: drm: panel: Add Samsung S6E8FC0 DSI controller for M1906F9 panel

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

The driver is well-structured and uses modern APIs. A few observations:

1. **Variable name `s6e8fc0_m1906f9_samsungp_mode`** (line 141): The `samsungp` suffix looks like a typo/leftover from the generator — should probably be `samsung_mode` or just `mode`. Very minor.

2. **Backlight LPM toggling** (lines 174, 180, 191, 197): The `mode_flags` manipulation in `s6e8fc0_bl_update_status` and `s6e8fc0_bl_get_brightness` is not thread-safe — if both are called concurrently, the flags could be corrupted. This is a common pattern in generated panel drivers and unlikely to cause real issues in practice, but worth noting.

3. **`mipi_dsi_dcs_set_display_brightness_multi` vs `_large` inconsistency**: In `s6e8fc0_m1906f9_on()` (line 64), `mipi_dsi_dcs_set_display_brightness_multi` is used (which sends a 1-byte brightness), but the backlight ops use `mipi_dsi_dcs_set_display_brightness_large` (2-byte). This is fine since the init sequence sets brightness to 0 and the actual brightness control goes through the backlight ops, but the inconsistency is worth being aware of.

4. **`max_brightness = 1023`** (line 214): The cover letter mentions downstream claims max 2047 but ignores the MSB. 1023 (10-bit) with `_large` (16-bit command) seems reasonable and is documented in the commit message. Good.

5. **Overall structure**: Uses `devm_drm_panel_alloc`, `devm_regulator_bulk_get_const`, `mipi_dsi_multi_context` — all modern best practices. The `container_of_const` usage in the accessor is correct. Probe/remove ordering (panel_add before attach, detach before panel_remove) is correct.

---

---
Generated by Claude Code Patch Reviewer