From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/meson: handle RGB101010 in format switches Date: Sun, 22 Mar 2026 03:12:28 +1000 Message-ID: In-Reply-To: <20260321-dsi-rgb101010-support-v4-2-eb28ecebbfe8@pm.me> References: <20260321-dsi-rgb101010-support-v4-0-eb28ecebbfe8@pm.me> <20260321-dsi-rgb101010-support-v4-2-eb28ecebbfe8@pm.me> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review ```c case MIPI_DSI_FMT_RGB101010: case MIPI_DSI_FMT_RGB666_PACKED: case MIPI_DSI_FMT_RGB565: return -EINVAL; ``` Straightforward addition to both switch statements to avoid `-Wswitch` warnings. Correctly marks RGB101010 as unsupported on this hardware by falling through to the error return/error message. **No issues.** This is the only non-MSM driver fixed, but other DSI host/bridge drivers that switch on `mipi_dsi_pixel_format` (e.g., `dw-mipi-dsi.c`, `samsung-dsim.c`, `tegra/dsi.c`, `mtk_dsi.c`, etc.) appear to have `default:` cases in their switches, so they won't generate warnings. Worth verifying with a build test across architectures. --- --- Generated by Claude Code Patch Reviewer