From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: th1520-dw-hdmi: Fix remove() callback Date: Sun, 22 Mar 2026 03:24:58 +1000 Message-ID: In-Reply-To: <20260321-th1520-v1-2-ec877197770d@gmail.com> References: <20260321-th1520-v1-0-ec877197770d@gmail.com> <20260321-th1520-v1-2-ec877197770d@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Verdict: Correct, good fix.** The original code was: ```c struct dw_hdmi *hdmi =3D platform_get_drvdata(pdev); dw_hdmi_remove(hdmi); ``` But `platform_set_drvdata(pdev, hdmi)` in probe stores a `struct th1520_hdm= i *`, not a `struct dw_hdmi *`. Casting the wrong type to `struct dw_hdmi *= ` and passing it to `dw_hdmi_remove()` would result in operating on garbage= data =E2=80=94 likely memory corruption or a crash on module removal. The fix correctly retrieves the proper type and dereferences the inner poin= ter: ```c struct th1520_hdmi *hdmi =3D platform_get_drvdata(pdev); dw_hdmi_remove(hdmi->dw_hdmi); ``` No issues. Both patches are straightforward, well-described, and suitable f= or merge. --- Generated by Claude Code Patch Reviewer