From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/imagination: Switch reset_reason fields from enum to u32 Date: Wed, 25 Mar 2026 07:34:16 +1000 Message-ID: In-Reply-To: <20260323-b4-firmware-context-reset-notification-handling-v3-2-1a66049a9a65@imgtec.com> References: <20260323-b4-firmware-context-reset-notification-handling-v3-0-1a66049a9a65@imgtec.com> <20260323-b4-firmware-context-reset-notification-handling-v3-2-1a66049a9a65@imgtec.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Verdict: Good with a minor note.** The rationale is correct =E2=80=94 `enum` is not a fixed-size type in C and= using it in firmware interface structures that must match a specific binar= y layout is fragile. The existing `pvr_rogue_fwif_check.h` offset checks (o= ffset 4, next field at offset 8) confirm the field is expected to be 4 byte= s, which `u32` guarantees. The `Fixes:` tag referencing the original FWIF headers commit is appropriat= e. One minor observation: `struct rogue_context_reset_reason_data` in `pvr_rog= ue_fwif_shared.h` is also changed, but I don't see a corresponding offset/s= ize check for that struct in the check headers. This is not a problem with = the patch itself, just a pre-existing gap. --- --- Generated by Claude Code Patch Reviewer