public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge-connector: Switch to using ->detect_ctx hook
Date: Wed, 25 Mar 2026 07:36:46 +1000	[thread overview]
Message-ID: <review-patch2-20260323-dw-hdmi-qp-scramb-v4-2-1d99df84883e@collabora.com> (raw)
In-Reply-To: <20260323-dw-hdmi-qp-scramb-v4-2-1d99df84883e@collabora.com>

Patch Review

**Overall: Looks correct but has a subtle concern.**

- **`drm_bridge_connector_get_modes_edid` calls `detect_ctx` with NULL ctx (line 303):** This means the internal locking path in `drm_bridge_detect_ctx()` will be used. For dw-hdmi-qp's `detect_ctx` implementation (patch 3), this could trigger `dw_hdmi_qp_reset_crtc()` which calls `drm_bridge_helper_reset_crtc()`. Doing a full CRTC reset inside `get_modes` seems unexpected and potentially problematic. However, this only triggers when `scramb_enabled` is true and the sink's SCDC state mismatches, so in practice during `get_modes` the pipeline should already be in a consistent state.

- **Removal of `.detect` from `drm_bridge_connector_funcs`:** The old `drm_bridge_connector_detect` is completely removed, and only `detect_ctx` is provided as a helper func. This means any code path that called `connector->funcs->detect()` directly will now get NULL. This should be fine since DRM core checks for `helper_funcs->detect_ctx` first (as of recent kernels), but it's a behavioral change worth being aware of for any out-of-tree users.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-24 21:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23 17:45 [PATCH RESEND v4 0/4] Add HDMI 2.0 support to DW HDMI QP TX Cristian Ciocaltea
2026-03-23 17:45 ` [PATCH RESEND v4 1/4] drm/bridge: Add ->detect_ctx hook and drm_bridge_detect_ctx() Cristian Ciocaltea
2026-03-24 21:36   ` Claude review: " Claude Code Review Bot
2026-03-23 17:45 ` [PATCH RESEND v4 2/4] drm/bridge-connector: Switch to using ->detect_ctx hook Cristian Ciocaltea
2026-03-24 21:36   ` Claude Code Review Bot [this message]
2026-03-23 17:45 ` [PATCH RESEND v4 3/4] drm/bridge: dw-hdmi-qp: Add high TMDS clock ratio and scrambling support Cristian Ciocaltea
2026-03-24 21:36   ` Claude review: " Claude Code Review Bot
2026-03-23 17:45 ` [PATCH RESEND v4 4/4] drm/rockchip: dw_hdmi_qp: Do not send HPD events for all connectors Cristian Ciocaltea
2026-03-24 21:36   ` Claude review: " Claude Code Review Bot
2026-03-24 21:36 ` Claude review: Add HDMI 2.0 support to DW HDMI QP TX Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-03  1:38 [PATCH v4 0/4] " Cristian Ciocaltea
2026-03-03  1:38 ` [PATCH v4 2/4] drm/bridge-connector: Switch to using ->detect_ctx hook Cristian Ciocaltea
2026-03-03  2:42   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260323-dw-hdmi-qp-scramb-v4-2-1d99df84883e@collabora.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox