From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/mxsfb/lcdif: simplify ep pointer management using __free Date: Tue, 31 Mar 2026 16:54:43 +1000 Message-ID: In-Reply-To: <20260330-drm-lcdif-dbanc-v2-2-c7f2af536a24@bootlin.com> References: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> <20260330-drm-lcdif-dbanc-v2-2-c7f2af536a24@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This converts the `ep` variable from `for_each_endpoint_of_node()` to use `= __free(device_node)`. The key question is whether `__free` interacts correc= tly with `for_each_endpoint_of_node` =E2=80=94 the macro reassigns `ep` on = each iteration. Since `__free` fires on scope exit (function return), and `= for_each_endpoint_of_node` internally calls `of_node_put` on the previous v= alue before assigning the next, the `__free` only needs to handle the early= -return case where the loop iterator hasn't been put yet. This is correct. No review/test tags since this is new in v2. Should get review. --- Generated by Claude Code Patch Reviewer