From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: waveshare-dsi: support DSI LCD kits with LVDS panels Date: Tue, 31 Mar 2026 17:17:00 +1000 Message-ID: In-Reply-To: <20260330-ws-lcd-v1-2-309834a435c0@oss.qualcomm.com> References: <20260330-ws-lcd-v1-0-309834a435c0@oss.qualcomm.com> <20260330-ws-lcd-v1-2-309834a435c0@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean and minimal change. Uses `i2c_get_match_data()` to retrieve the connector type from match data, which is the correct modern pattern. ```c ws->bridge.type = (uintptr_t)i2c_get_match_data(i2c); ``` The cast from `void *` via `uintptr_t` to the enum type is the standard pattern used elsewhere in the kernel for storing small integer values in OF match data. This is correct. ```c {.compatible = "waveshare,dsi2dpi", .data = (void *)DRM_MODE_CONNECTOR_DPI, }, {.compatible = "waveshare,dsi2lvds", .data = (void *)DRM_MODE_CONNECTOR_LVDS, }, ``` No issues with this patch. --- Generated by Claude Code Patch Reviewer