public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: Add driver for Novatek NT35532
Date: Wed, 01 Apr 2026 07:57:44 +1000	[thread overview]
Message-ID: <review-patch2-20260331-rimob-new-features-v5-2-5fcf42a29c12@protonmail.com> (raw)
In-Reply-To: <20260331-rimob-new-features-v5-2-5fcf42a29c12@protonmail.com>

Patch Review

The driver is cleanly structured and uses modern APIs (`devm_drm_panel_alloc`, `mipi_dsi_multi_context`, `devm_regulator_bulk_get_const`).

**Minor issue - inconsistent sleep/display-on commands in `rimob_panel_on()`:**

```c
mipi_dsi_generic_write_seq_multi(&dsi_ctx, MIPI_DCS_EXIT_SLEEP_MODE, 0x00);
mipi_dsi_msleep(&dsi_ctx, 120);
mipi_dsi_generic_write_seq_multi(&dsi_ctx, MIPI_DCS_SET_DISPLAY_ON, 0x00);
```

These use `mipi_dsi_generic_write_seq_multi` to send a generic MIPI packet containing `{0x11, 0x00}` / `{0x29, 0x00}`. But `nt35532_off()` correctly uses the DCS-specific helpers:

```c
mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
```

Generic writes and DCS commands use different MIPI DSI packet types. Since this is auto-generated from vendor DT it may work fine in practice, but it's inconsistent and worth considering whether the on-path should also use `mipi_dsi_dcs_exit_sleep_mode_multi()` and `mipi_dsi_dcs_set_display_on_multi()` for consistency and correctness.

The `of_device_id` table only matches the specific compatible `"flipkart,rimob-panel-nt35532-cs"` and not the fallback `"novatek,nt35532"`. This is correct - the fallback is for future drivers/panels that share the same DDIC, and the specific compatible carries the init sequence data via `.data`.

Already has `Reviewed-by: Dmitry Baryshkov`.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-31 21:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31  9:47 [PATCH v5 0/6] Enable new features for flipkart-rimob Cristian Cozzolino via B4 Relay
2026-03-31  9:47 ` [PATCH v5 1/6] dt-bindings: display: panel: Add Novatek NT35532 LCD DSI Cristian Cozzolino via B4 Relay
2026-03-31 21:57   ` Claude review: " Claude Code Review Bot
2026-03-31  9:47 ` [PATCH v5 2/6] drm/panel: Add driver for Novatek NT35532 Cristian Cozzolino via B4 Relay
2026-03-31 21:57   ` Claude Code Review Bot [this message]
2026-03-31  9:47 ` [PATCH v5 3/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable display and GPU Cristian Cozzolino via B4 Relay
2026-03-31 21:57   ` Claude review: " Claude Code Review Bot
2026-03-31  9:47 ` [PATCH v5 4/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable WiFi/Bluetooth Cristian Cozzolino via B4 Relay
2026-03-31 21:57   ` Claude review: " Claude Code Review Bot
2026-03-31  9:47 ` [PATCH v5 5/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable touchscreen Cristian Cozzolino via B4 Relay
2026-03-31 21:57   ` Claude review: " Claude Code Review Bot
2026-03-31  9:47 ` [PATCH v5 6/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable Hall sensor Cristian Cozzolino via B4 Relay
2026-03-31 21:57   ` Claude review: " Claude Code Review Bot
2026-03-31 21:57 ` Claude review: Enable new features for flipkart-rimob Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-21 16:23 [PATCH v3 0/6] " Cristian Cozzolino via B4 Relay
2026-03-21 16:23 ` [PATCH v3 2/6] drm/panel: Add driver for Novatek NT35532 Cristian Cozzolino via B4 Relay
2026-03-21 17:00   ` Claude review: " Claude Code Review Bot
2026-03-18 22:28 [PATCH v2 0/6] Enable new features for flipkart-rimob Cristian Cozzolino via B4 Relay
2026-03-18 22:28 ` [PATCH v2 2/6] drm/panel: Add driver for Novatek NT35532 Cristian Cozzolino via B4 Relay
2026-03-21 19:00   ` Claude review: " Claude Code Review Bot
2026-03-08 15:52 [PATCH 0/6] Enable new features for flipkart-rimob Cristian Cozzolino via B4 Relay
2026-03-08 15:52 ` [PATCH 2/6] drm/panel: Add driver for Novatek NT35532 Cristian Cozzolino via B4 Relay
2026-03-08 21:46   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260331-rimob-new-features-v5-2-5fcf42a29c12@protonmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox