From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm: Remove abuse of drm_exec internals Date: Wed, 01 Apr 2026 07:52:57 +1000 Message-ID: In-Reply-To: <20260331092023.81616-3-thomas.hellstrom@linux.intel.com> References: <20260331092023.81616-1-thomas.hellstrom@linux.intel.com> <20260331092023.81616-3-thomas.hellstrom@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Looks good.** The old code checked `submit->exec.objects` to determine if= `drm_exec_init()` had been called =E2=80=94 this relies on undocumented in= ternal state. Adding `bool has_exec : 1` to `struct msm_gem_submit` and setting it at bot= h init paths (`submit_lock_objects_vmbind` and `submit_lock_objects`) is th= e right fix: ```c + submit->has_exec =3D true; ``` The cleanup path change from: ```c - if (submit->exec.objects) + if (submit->has_exec) ``` is correct and self-documenting. Minor observation: `msm_gem_submit` is allocated via `kzalloc`-like functio= ns, so `has_exec` starts as `false` without explicit initialization =E2=80= =94 this is fine. --- --- Generated by Claude Code Patch Reviewer