From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: vt: Implement helpers for struct vc_font in source file Date: Sun, 12 Apr 2026 13:55:02 +1000 Message-ID: In-Reply-To: <20260407092555.58816-3-tzimmermann@suse.de> References: <20260407092555.58816-1-tzimmermann@suse.de> <20260407092555.58816-3-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Verdict: Fine, straightforward.** Moves `vc_font_pitch()` and `vc_font_size()` from inline in `console_struct.h` to out-of-line in `vt.c`. These are not hot-path functions, so the loss of inlining is irrelevant. Removes `#include ` from the widely-included header, which is a minor positive. Already has Acked-by from Greg KH. No issues. --- --- Generated by Claude Code Patch Reviewer