From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: Move legacy bridge driver out of imx directory for multi-platform use Date: Sun, 12 Apr 2026 11:37:39 +1000 Message-ID: In-Reply-To: <20260409065301.446670-3-damon.ding@rock-chips.com> References: <20260409065301.446670-1-damon.ding@rock-chips.com> <20260409065301.446670-3-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Moves `imx-legacy-bridge.c` to `of-display-mode-bridge.c` at the top-level bridge directory, renames all structs/functions accordingly, updates Kconfig/Makefile, and changes consumers (`imx-ldb.c`, `parallel-display.c`). The new header `of-display-mode-bridge.h` replaces `imx.h`. The rename is clean and mechanical. The new driver is functionally identical to the old one. The Kconfig change from `DRM_IMX_LEGACY_BRIDGE` to `DRM_OF_DISPLAY_MODE_BRIDGE` is correct in all consumers. Minor note: `of_display_mode_bridge_funcs` should probably be `static const` (it was already non-static non-const in the original, so this isn't a regression): ```c struct drm_bridge_funcs of_display_mode_bridge_funcs = { ``` No blocking issues. --- Generated by Claude Code Patch Reviewer