From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Split register definitions by components Date: Sun, 12 Apr 2026 09:38:15 +1000 Message-ID: In-Reply-To: <20260410164637.549145-3-karunika.choo@arm.com> References: <20260410164637.549145-1-karunika.choo@arm.com> <20260410164637.549145-3-karunika.choo@arm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Approach**: Splits the monolithic `panthor_regs.h` into per-component headers (`panthor_gpu_regs.h`, `panthor_mmu_regs.h`, `panthor_fw_regs.h`, `panthor_pwr_regs.h`, `panthor_hw_regs.h`) and updates includes. This looks correct. The register definitions are faithfully moved without changing values. Each source file includes the headers it needs. The old `panthor_regs.h` is removed. Minor note: the original `panthor_regs.h` had a copyright block referencing Marty Plummer, Rob Herring, Collabora, and ARM. The new split headers only have `Copyright 2026 ARM Limited`. The original copyright attributions should be preserved in the files that contain the definitions originally covered by those copyrights. --- Generated by Claude Code Patch Reviewer