From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/pagemap: Drop source_peer_migrates flag and assume true Date: Sun, 12 Apr 2026 09:24:51 +1000 Message-ID: In-Reply-To: <20260410205929.3914474-3-matthew.brost@intel.com> References: <20260410205929.3914474-1-matthew.brost@intel.com> <20260410205929.3914474-3-matthew.brost@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean simplification. The commit message correctly justifies the removal: all current users set this to true, and the flag's interaction with high-speed fabric mapping APIs is questionable. The code change in `drm_pagemap.c:651-662` correctly removes the `if (mdetails->source_peer_migrates)` guard and unconditionally executes the body. The `xe_svm.c` removal of the `.source_peer_migrates = 1` initializer and the `drm_pagemap.h` struct cleanup are consistent. The kerneldoc update for `can_migrate_same_pagemap` is a nice touch -- removing the stale reference to `source_peer_migrates` in its description. No issues. --- --- Generated by Claude Code Patch Reviewer