Claude review: drm/panel: support Waveshare DSI TOUCH kits

Claude Code Review Bot
2026-04-11T23:06:52Z

Overall Series Review

Subject: drm/panel: support Waveshare DSI TOUCH kits
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patches: 23
Reviewed: 2026-04-12T09:06:52.916476

---

This is a 21-patch series by Dmitry Baryshkov adding support for the Waveshare DSI TOUCH family of panel kits. The series covers dt-bindings (patches 1-5, 20), a DRM OF helper (patch 6), panel driver additions/refactors (patches 7-19), and a GPIO/backlight controller driver (patch 21). The work is well-structured with preparatory refactoring cleanly separated from new panel additions.

However, there are several bugs that need fixing before merge:
- **Patch 5**: DT binding has an internally contradictory schema (`vcc-supply` defined vs `vccio-supply` required) and a compatible string typo (`8.88` vs `8.8`)
- **Patch 12**: Signedness bug assigning a potentially negative error code to `unsigned int dsi->lanes`
- **Patch 15/16**: Two init functions return `0` instead of `dsi_ctx.accum_err`, silently swallowing DSI errors
- **Patch 19**: `devm_drm_panel_alloc()` returns `ERR_PTR`, not NULL -- the check is wrong; also commas used instead of semicolons; wrong variable in error message
- **Patch 21**: `regmap max_register` is too low, blocking reads to ID/version registers used in probe

---

---
Generated by Claude Code Patch Reviewer