From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: waveshare-dsi: support DSI LCD kits with LVDS panels Date: Mon, 13 Apr 2026 18:54:38 +1000 Message-ID: In-Reply-To: <20260412-ws-lcd-v3-2-db22c2631828@oss.qualcomm.com> References: <20260412-ws-lcd-v3-0-db22c2631828@oss.qualcomm.com> <20260412-ws-lcd-v3-2-db22c2631828@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Clean driver change. The approach uses `i2c_get_match_data()` to retrieve t= he connector type from the OF match table, which is the preferred kernel pa= ttern for parameterizing drivers by compatible string. 1. **Match data retrieval**: ```c - ws->bridge.type =3D DRM_MODE_CONNECTOR_DPI; + ws->bridge.type =3D (uintptr_t)i2c_get_match_data(i2c); ``` The `(uintptr_t)` cast from `const void *` is the standard idiom seen throu= ghout the DRM subsystem (e.g., `display-connector.c`, `lvds-codec.c`). `DRM= _MODE_CONNECTOR_DPI` is 17 and `DRM_MODE_CONNECTOR_LVDS` is 7 =E2=80=94 bot= h non-zero, so there's no ambiguity with NULL. `i2c_get_match_data` will ch= eck OF match data, which is correct here since the driver only has an `of_d= evice_id` table (no `i2c_device_id` table with data). 2. **Match table update**: ```c - {.compatible =3D "waveshare,dsi2dpi",}, + {.compatible =3D "waveshare,dsi2dpi", .data =3D (void *)DRM_MODE_CONNECTO= R_DPI, }, + {.compatible =3D "waveshare,dsi2lvds", .data =3D (void *)DRM_MODE_CONNECT= OR_LVDS, }, ``` Correct =E2=80=94 maintains backward compatibility for existing `dsi2dpi` D= Ts while adding the new LVDS variant. One minor observation: there's no `MODULE_DESCRIPTION` update to mention LV= DS (currently says "Waveshare DSI2DPI bridge driver"), but that's cosmetic = and not worth holding the patch for. No functional issues. The series is minimal, correct, and ready to apply. --- Generated by Claude Code Patch Reviewer