From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Split register definitions by components Date: Mon, 13 Apr 2026 19:05:52 +1000 Message-ID: In-Reply-To: <20260412142951.2309135-3-karunika.choo@arm.com> References: <20260412142951.2309135-1-karunika.choo@arm.com> <20260412142951.2309135-3-karunika.choo@arm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Good.** Splits the monolithic `panthor_regs.h` (291 lines) into four component-spec= ific headers: - `panthor_gpu_regs.h` =E2=80=94 GPU_CONTROL and GPU_INT registers - `panthor_fw_regs.h` =E2=80=94 MCU_CONTROL registers - `panthor_mmu_regs.h` =E2=80=94 MMU_INT and MMU_AS registers - `panthor_pwr_regs.h` =E2=80=94 PWR_CONTROL and PWR_INT registers The split is clean and each file gets the correct subset of defines. The ol= d `panthor_regs.h` is deleted. Each source file now includes only the regis= ter header it needs. One observation: the cover letter mentions that `panthor_gpu_regs.h` is inc= luded from `panthor_hw.c` because `panthor_gpu_info_init()` reads GPU regis= ters directly (ID, features, etc.). This is addressed properly in later pat= ches (5, 6) where `panthor_hw.c` gets a local iomem pointer passed in. --- --- Generated by Claude Code Patch Reviewer