public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: simple: Add timings for Raspberry Pi 7" panel
Date: Thu, 23 Apr 2026 09:39:22 +1000	[thread overview]
Message-ID: <review-patch2-20260420-rpi-7inch-v1-2-e68d5c9c44bc@ideasonboard.com> (raw)
In-Reply-To: <20260420-rpi-7inch-v1-2-e68d5c9c44bc@ideasonboard.com>

Patch Review

The commit message is excellent — it documents the strict back-porch requirements, the connector type rationale, and the hardware topology clearly.

**Timing analysis:**

The timing definition looks correct for an 800x480 panel. The typical pixel clock of 30MHz gives approximately 60fps:
- htotal = 800 + 72 + 32 + 46 = 950
- vtotal = 480 + 21 + 2 + 23 = 526
- 30MHz / (950 * 526) = ~60.0 Hz

The fixed back-porch values (hbp=46, vbp=23 with min=typ=max) match the commit message's claim that these must be exact. The wide pixel clock range (10–50MHz) allows flexible refresh rate selection, which is reasonable for a panel behind a DSI-to-DPI bridge where the host controller determines the actual rate.

**Observation — similarity to rocktech_rk070er9427:**

The existing `rocktech_rk070er9427` panel at line 4274 shares strikingly similar parameters: same resolution (800x480), same physical size (154x86mm), identical fixed back-porches (hbp=46, vbp=23), and overlapping front-porch/pixel-clock ranges. The main differences are bpc (6 vs 8), bus_format (RGB666_1X18 vs RGB888_1X24), and the new panel's bus_flags/sync flags. This might suggest Rocktech is one of the undisclosed panel vendors — not a problem for the patch, but an interesting data point.

**bus_flags usage:**

The patch uses `DRM_BUS_FLAG_SYNC_DRIVE_POSEDGE` and `DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE` in the `panel_desc.bus_flags`. These are from the transmitter's perspective (DRIVE), not the receiver/panel perspective (SAMPLE). Since `DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE` == `DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE` (both BIT(2)), and similarly for sync, these will pass the DPI validation checks at line 664 without warnings.

This is consistent with how several other panels in the file define their bus_flags (e.g., lines 1644, 1851, 2123-2124), so this is fine. However, given the comment in the timing struct:

```c
	/* Note: the rest of the flags are defined below in bus_flags */
```

It's worth noting that `DISPLAY_FLAGS_VSYNC_HIGH | DISPLAY_FLAGS_HSYNC_HIGH` in the timing struct defines sync polarity (which sync level is active), while `DRM_BUS_FLAG_SYNC_DRIVE_POSEDGE` in bus_flags defines the clock edge on which sync is driven — these are orthogonal, so no conflict. The comment might mislead a reader into thinking the bus_flags are an alternative location for the *same* kind of flags, when they're actually complementary. This is a very minor nit.

**of_device_id table:**

The entry is correctly placed in alphabetical order between `qishenglong,gopher2b-lcd` and `raystar,rff500f-awh-dnn` at the updated line 5519.

**No blocking issues.**

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-22 23:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 13:13 [PATCH 0/2] drm/panel: Add Raspberry Pi 7" panel Tomi Valkeinen
2026-04-20 13:13 ` [PATCH 1/2] dt-bindings: display: simple: Add Raspberry Pi 7" DSI Display module panel Tomi Valkeinen
2026-04-20 16:01   ` Conor Dooley
2026-04-22 23:39   ` Claude review: " Claude Code Review Bot
2026-04-20 13:13 ` [PATCH 2/2] drm/panel: simple: Add timings for Raspberry Pi 7" panel Tomi Valkeinen
2026-04-22 19:22   ` Dmitry Baryshkov
2026-04-22 23:39   ` Claude Code Review Bot [this message]
2026-04-22 23:39 ` Claude review: drm/panel: Add " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260420-rpi-7inch-v1-2-e68d5c9c44bc@ideasonboard.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox