From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/hibmc: Fix list of formats on the primary plane
Date: Thu, 23 Apr 2026 10:03:23 +1000
Message-ID: <review-patch2-20260420121130.200133-3-tzimmermann@suse.de>
In-Reply-To: <20260420121130.200133-3-tzimmermann@suse.de>
References: <20260420121130.200133-1-tzimmermann@suse.de> <20260420121130.200133-3-tzimmermann@suse.de>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Status: Good**

Reduces the format list from 10 entries to 2:

```c
static const u32 channel_formats1[] = {
    DRM_FORMAT_XRGB8888,
    DRM_FORMAT_RGB565,
};
```

The commit message provides clear justification for each removal:
- Alpha formats (ARGB8888, RGBA8888, etc.): no transparency support in the plane implementation.
- BGR formats: no BGR channel order support in the implementation.
- RGB888: the `cpp[0] * 8 / 16` formula in `atomic_update` computes `3 * 8 / 16 = 1` (truncated), which programs the hardware for RGB565, producing distorted output.

All three categories are genuine bugs where the driver advertises formats it can't correctly handle. The Cc: stable tag is appropriate. Correctly carries a Fixes tag.

No issues.

---
Generated by Claude Code Patch Reviewer