From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbdev: clps711x-fb: Request memory region for MMIO
Date: Thu, 23 Apr 2026 09:34:40 +1000
Message-ID: <review-patch2-20260420134424.77494-3-amit.barzilai22@gmail.com>
In-Reply-To: <20260420134424.77494-3-amit.barzilai22@gmail.com>
References: <20260420134424.77494-1-amit.barzilai22@gmail.com> <20260420134424.77494-3-amit.barzilai22@gmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Status: Good**

Makes resource 0 (MMIO registers) consistent with resource 1 (framebuffer),=
 which already uses `devm_platform_get_and_ioremap_resource()` at line 231 =
of the current source. Good consistency improvement.

```c
cfb->base =3D devm_platform_get_and_ioremap_resource(pdev, 0, &res);
if (IS_ERR(cfb->base)) {
    ret =3D PTR_ERR(cfb->base);
    goto out_fb_release;
}
```

The original code had a subtle deficiency: when `platform_get_resource()` r=
eturned NULL, it jumped to `out_fb_release` with `ret` still at its init va=
lue of `-ENOENT` (line 206 of current source). While not a bug per se, the =
new code is better =E2=80=94 `ret` is explicitly set to the actual error fr=
om the helper.

`res` is still used afterward (lines 228-229: `info->fix.mmio_start =3D res=
->start; info->fix.mmio_len =3D resource_size(res)`), and it's correctly po=
pulated by the `&res` output parameter.

No issues.

---
Generated by Claude Code Patch Reviewer