From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: pass down IRQ_HPD to the drivers Date: Thu, 23 Apr 2026 09:07:43 +1000 Message-ID: In-Reply-To: <20260421-hpd-irq-events-v3-2-44d2bf40dfc2@oss.qualcomm.com> References: <20260421-hpd-irq-events-v3-0-44d2bf40dfc2@oss.qualcomm.com> <20260421-hpd-irq-events-v3-2-44d2bf40dfc2@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This is the largest patch -- a mechanical update of callback signatures across the bridge subsystem. All the changes are consistent: - `hpd_notify` funcs pointer: gains `enum drm_connector_status_extra extra_status` - `hpd_cb` function pointer: same - `drm_bridge_hpd_enable()`: callback parameter updated - `oob_hotplug_event` funcs pointer: same - All bridge driver callbacks updated to accept but ignore the new parameter (correct -- non-DP bridges don't need it) **Key correctness check** -- In `drm_bridge.c`, the existing `drm_bridge_hpd_notify()` passes `DRM_CONNECTOR_NO_EXTRA_STATUS` to the updated `hpd_cb`: ```c bridge->hpd_cb(bridge->hpd_data, status, DRM_CONNECTOR_NO_EXTRA_STATUS); ``` This is correct for backward compatibility -- callers that don't know about IRQ_HPD continue to work. In `drm_bridge_connector.c`, `drm_bridge_connector_detect()` correctly passes `DRM_CONNECTOR_NO_EXTRA_STATUS` since polling-based detection doesn't have IRQ events. **Minor cosmetic issue:** In `ti-tfp410.c`, a blank line between `drm_bridge_to_tfp410()` and `drm_connector_to_tfp410()` is removed. This is unrelated to the IRQ_HPD changes: ```c -} - -static inline struct tfp410 * +} +static inline struct tfp410 * ``` Consider keeping the blank line to avoid unnecessary churn. --- Generated by Claude Code Patch Reviewer