From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: rust: io: generalize `Mmio` to arbitrary type Date: Thu, 23 Apr 2026 08:25:45 +1000 Message-ID: In-Reply-To: <20260421-io_projection-v2-2-4c251c692ef4@garyguo.net> References: <20260421-io_projection-v2-0-4c251c692ef4@garyguo.net> <20260421-io_projection-v2-2-4c251c692ef4@garyguo.net> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Changes `Mmio` to `Mmio`. Adds `MIN_SIZE` to `KnownSize` trait. Mostly mechanical updates to doc examples changing `Mmio` to `Mmio>`. The `MIN_SIZE` additions are sensible: ```rust impl KnownSize for T { const MIN_SIZE: usize = core::mem::size_of::(); } impl KnownSize for [T] { const MIN_SIZE: usize = 0; } ``` This is correct -- sized types have a fixed known size, slices have minimum 0. Clean patch. --- Generated by Claude Code Patch Reviewer