From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: use warn_on_err macro
Date: Thu, 23 Apr 2026 08:52:55 +1000
Message-ID: <review-patch2-20260421-nova-unload-v2-2-2fe54963af8b@nvidia.com>
In-Reply-To: <20260421-nova-unload-v2-2-2fe54963af8b@nvidia.com>
References: <20260421-nova-unload-v2-0-2fe54963af8b@nvidia.com> <20260421-nova-unload-v2-2-2fe54963af8b@nvidia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**File:** `drivers/gpu/nova-core/gpu.rs`

```rust
-        kernel::warn_on!(self
-            .bar
-            .access(dev)
-            .inspect(|bar| self.sysmem_flush.unregister(bar))
-            .is_err());
+        let Ok(bar) = kernel::warn_on_err!(self.bar.access(dev)) else {
+            return;
+        };
+
+        self.sysmem_flush.unregister(bar);
```

Good refactor. The old code used `inspect()` to piggyback the unregister call inside a chain, which was harder to read and prevented adding more teardown steps. The new code uses `let-else` to early-return on failure, making the bar available for subsequent use. This is an important prep for patches 4 and 5 which add more teardown steps that need the bar.

No issues.

---
Generated by Claude Code Patch Reviewer