From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tegra: fbdev: Remove offset into framebuffer memory Date: Thu, 23 Apr 2026 08:46:58 +1000 Message-ID: In-Reply-To: <20260421073646.144712-3-tzimmermann@suse.de> References: <20260421073646.144712-1-tzimmermann@suse.de> <20260421073646.144712-3-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Good** This removes the `xoffset`/`yoffset` adjustment from `screen_buffer` and `smem_start`: ```c - offset = info->var.xoffset * bytes_per_pixel + - info->var.yoffset * fb->pitches[0]; ... - info->screen_buffer = bo->vaddr + offset; + info->screen_buffer = bo->vaddr; ... - info->fix.smem_start = (unsigned long)(bo->iova + offset); + info->fix.smem_start = (unsigned long)(bo->iova); ``` `screen_buffer` should point to the start of the framebuffer memory region, not offset by display scroll position. The xoffset/yoffset values describe panning within scanout, not the base address of the buffer. This matches how every other fbdev driver in the kernel sets up `screen_buffer`. The Fixes tag pointing all the way back to v3.10 and Cc: stable are appropriate given this has always been wrong. No issues. --- Generated by Claude Code Patch Reviewer