public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/gem/shmem: Introduce __drm_gem_shmem_free_sgt_locked()
Date: Thu, 23 Apr 2026 08:09:05 +1000	[thread overview]
Message-ID: <review-patch2-20260421234234.638503-3-lyude@redhat.com> (raw)
In-Reply-To: <20260421234234.638503-3-lyude@redhat.com>

Patch Review

**Concern: Missing NULL check on `shmem->sgt`.**

The extracted function unconditionally dereferences `shmem->sgt`:

```c
void __drm_gem_shmem_free_sgt_locked(struct drm_gem_shmem_object *shmem)
{
	dma_resv_assert_held(shmem->base.resv);

	dma_unmap_sgtable(shmem->base.dev->dev, shmem->sgt, DMA_BIDIRECTIONAL, 0);
	sg_free_table(shmem->sgt);
	kfree(shmem->sgt);
	shmem->sgt = NULL;
}
```

The original code in `drm_gem_shmem_release()` wrapped this with `if (shmem->sgt)`. The call site in `drm_gem_shmem_release` still checks `if (shmem->sgt)` before calling the new function, and the Rust callers (patch 4) also only call it when the sgt is known-valid. So this is safe in practice, but since the function is exported and documented, it would be more defensive to either:
- Add a NULL check inside the function, or
- Document in the kdoc that `shmem->sgt` must be non-NULL.

Currently the kdoc says "If the passed shmem object has an active scatter/gather table..." which implies it handles the NULL case, but it doesn't.

**Minor: Doc/function name mismatch in commit message.** The commit message references `__drm_gem_shmem_release_sgt_locked()` in the V10 changelog, but the actual function is `__drm_gem_shmem_free_sgt_locked()`. This is just the changelog, not the code, so it's a cosmetic issue only.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-22 22:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-21 23:40 [PATCH v11 0/5] Rust bindings for gem shmem Lyude Paul
2026-04-21 23:40 ` [PATCH v11 1/5] rust: drm: gem: s/device::Device/Device/ for shmem.rs Lyude Paul
2026-04-22 22:09   ` Claude review: " Claude Code Review Bot
2026-04-21 23:40 ` [PATCH v11 2/5] drm/gem/shmem: Introduce __drm_gem_shmem_free_sgt_locked() Lyude Paul
2026-04-22 22:09   ` Claude Code Review Bot [this message]
2026-04-21 23:40 ` [PATCH v11 3/5] drm/gem/shmem: Export drm_gem_shmem_get_pages_sgt_locked() Lyude Paul
2026-04-22 22:09   ` Claude review: " Claude Code Review Bot
2026-04-21 23:40 ` [PATCH v11 4/5] rust: drm: gem: Introduce shmem::SGTable Lyude Paul
2026-04-22 22:09   ` Claude review: " Claude Code Review Bot
2026-04-21 23:40 ` [PATCH v11 5/5] rust: drm: gem: Add vmap functions to shmem bindings Lyude Paul
2026-04-22 22:09   ` Claude review: " Claude Code Review Bot
2026-04-21 23:48 ` [PATCH v11 0/5] Rust bindings for gem shmem Lyude Paul
2026-04-22 22:09 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-21 23:52 [PATCH v12 0/5] " Lyude Paul
2026-04-21 23:52 ` [PATCH v12 2/5] drm/gem/shmem: Introduce __drm_gem_shmem_free_sgt_locked() Lyude Paul
2026-04-22 22:05   ` Claude review: " Claude Code Review Bot
2026-04-09  0:12 [PATCH v10 0/5] Rust bindings for gem shmem Lyude Paul
2026-04-09  0:12 ` [PATCH v10 2/5] drm/gem/shmem: Introduce __drm_gem_shmem_free_sgt_locked() Lyude Paul
2026-04-12  2:01   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260421234234.638503-3-lyude@redhat.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox