From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdgpu/jpeg: deduplicate jpeg_v5_3_0 process_interrupt Date: Thu, 23 Apr 2026 07:56:59 +1000 Message-ID: In-Reply-To: <20260422003911.33841-3-tiagodourado@usp.br> References: <20260422003911.33841-1-tiagodourado@usp.br> <20260422003911.33841-3-tiagodourado@usp.br> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness:** The deleted `jpeg_v5_3_0_process_interrupt` is verified id= entical to `jpeg_v5_0_0_process_interrupt` =E2=80=94 both use `VCN_5_0__SRC= ID__JPEG_DECODE`, `DRM_DEV_ERROR`, and `adev->jpeg.inst->ring_dec`. The ded= uplication is valid. **Same style concern =E2=80=94 unnecessary macro alias:** ```c #define jpeg_v5_3_0_process_interrupt jpeg_v5_0_0_process_interrupt ``` Same feedback as patch 1: drop the macro and assign `.process =3D jpeg_v5_0= _0_process_interrupt` directly in the `jpeg_v5_3_0_irq_funcs` struct. **Same tag ordering issue** as patch 1 =E2=80=94 submitter's `Signed-off-by= ` should be last. --- Generated by Claude Code Patch Reviewer