From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Date: Thu, 23 Apr 2026 07:50:44 +1000 Message-ID: In-Reply-To: <20260422092409.4107093-3-ekansh.gupta@oss.qualcomm.com> References: <20260422092409.4107093-1-ekansh.gupta@oss.qualcomm.com> <20260422092409.4107093-3-ekansh.gupta@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Assessment: Clean improvement, no issues.** Replaces `0xFF0` with `GENMASK(11, 4)` and converts manual shifts to `FIELD_PREP`/`FIELD_GET`. The three conversion sites are correct: - `ctx->ctxid >> 4` becomes `FIELD_GET(FASTRPC_CTXID_MASK, ctx->ctxid)` - `ret << 4` becomes `FIELD_PREP(FASTRPC_CTXID_MASK, ret)` - `(rsp->ctx & FASTRPC_CTXID_MASK) >> 4` becomes `FIELD_GET(FASTRPC_CTXID_MASK, rsp->ctx)` The `#include ` is added but `FIELD_PREP`/`FIELD_GET` come from ``. This would work only if `bitfield.h` is transitively included. Consider adding an explicit `#include ` instead. Already has Konrad's Reviewed-by, which is appropriate. --- --- Generated by Claude Code Patch Reviewer