From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbdev: i810: Use safer strscpy() instead of strcpy() Date: Tue, 28 Apr 2026 15:38:39 +1000 Message-ID: In-Reply-To: <20260425065926.1091168-3-aichao@kylinos.cn> References: <20260425065926.1091168-1-aichao@kylinos.cn> <20260425065926.1091168-3-aichao@kylinos.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Files:** `i810-i2c.c`, `i810_main.c` =E2=80=94 2 replacements The string conversions themselves are fine: - `name` =E2=86=92 `chan->adapter.name` (`char[48]`) - `"I810"` (5 bytes) =E2=86=92 `fix->id` (`char[16]`) **Issue: undeclared whitespace change.** Both hunks silently convert leadin= g spaces to tabs: ```c - strcpy(chan->adapter.name, name); + strscpy(chan->adapter.name, name); ``` ```c - strcpy(fix->id, "I810"); + strscpy(fix->id, "I810"); ``` The commit message says "Only idiomatic code replacement, and no functional= changes" but the indentation change is a separate style fix that should ei= ther be split out or mentioned. Mixing whitespace changes with functional c= hanges makes `git blame` noisier. --- --- Generated by Claude Code Patch Reviewer