From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: Extract usable FB region from GSP Date: Tue, 28 Apr 2026 15:31:59 +1000 Message-ID: In-Reply-To: <20260425211454.174696-3-joelagnelf@nvidia.com> References: <20260425211454.174696-1-joelagnelf@nvidia.com> <20260425211454.174696-3-joelagnelf@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `fb_regions()` iterator and `first_usable_fb_region()` to extract the first usable VRAM region from GSP firmware data. Uses `checked_add(1)` consistently for inclusive-to-exclusive limit conversion. The TODO acknowledging that multiple discontinuous usable regions are possible but not yet supported is appropriate. The filter logic (`reserved == 0 && bProtected == 0 && supportCompressed != 0 && supportISO != 0`) looks correct for selecting allocatable VRAM. No significant issues. The `#[expect(dead_code)]` on `usable_fb_region` is correct for bisectability. --- Generated by Claude Code Patch Reviewer