public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Documentation: drm: Remove drm_atomic_state rename entry
Date: Tue, 28 Apr 2026 14:55:34 +1000	[thread overview]
Message-ID: <review-patch2-20260427-drm-drm-atomic-update-v4-2-c0e713bfdf25@kernel.org> (raw)
In-Reply-To: <20260427-drm-drm-atomic-update-v4-2-c0e713bfdf25@kernel.org>

Patch Review

**Status: Looks correct.**

This patch removes the 23-line todo entry from `Documentation/gpu/todo.rst` that described the `drm_atomic_state` rename task, since patch 1/2 just completed it.

The diff is clean — it removes exactly the "Rename drm_atomic_commit" section (which at this point in the series has already been mechanically renamed by patch 1/2 from its original "Rename drm_atomic_state" title). The context lines show the surrounding sections ("Level: Advanced" above, "Fallout from atomic KMS" below) are untouched.

One observation about the intermediate state after patch 1/2 but before this patch: the todo text would read:

```
``drm_atomic_commit`` should be renamed to something clearer like
``drm_atomic_commit``.
```

This is nonsensical (recommending renaming something to itself), which is an expected artifact of the mechanical rename in patch 1. Patch 2 immediately cleans this up, so the intermediate state is only visible in `git log` but never in a released kernel. This is fine, though squashing patch 2 into patch 1 would have avoided the nonsensical intermediate commit. That said, keeping them separate is a reasonable editorial choice since it makes the mechanical rename easier to audit.

Tags present: Reviewed-by (Luca Ceresoli), Acked-by (Jani Nikula), Signed-off-by (Maxime Ripard). No issues.

**Verdict: Patch 2/2 is straightforward and correct. Patch 1/2 cannot be reviewed because it's missing from the mbox. The series should be re-submitted or the mbox re-fetched to include patch 1/2 for a complete review.**

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-28  4:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27  7:02 [PATCH v4 0/2] drm: Rename drm_atomic_state Maxime Ripard
2026-04-27  7:02 ` [PATCH v4 2/2] Documentation: drm: Remove drm_atomic_state rename entry Maxime Ripard
2026-04-28  4:55   ` Claude Code Review Bot [this message]
2026-04-28  4:55 ` Claude review: drm: Rename drm_atomic_state Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-31 14:41 [PATCH v2 0/2] " Maxime Ripard
2026-03-31 14:41 ` [PATCH v2 2/2] Documentation: drm: Remove drm_atomic_state rename entry Maxime Ripard
2026-03-31 21:41   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260427-drm-drm-atomic-update-v4-2-c0e713bfdf25@kernel.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox