From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: do not import firmware commands into GSP command module Date: Tue, 28 Apr 2026 15:01:47 +1000 Message-ID: In-Reply-To: <20260427-nova-unload-v4-2-e145ccddae66@nvidia.com> References: <20260427-nova-unload-v4-0-e145ccddae66@nvidia.com> <20260427-nova-unload-v4-2-e145ccddae66@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Replaces `use fw::commands::*` with `use fw` and qualifies all references (= e.g., `GspSetSystemInfo` =E2=86=92 `fw::commands::GspSetSystemInfo`). This = is a good namespace hygiene change and the commit message correctly explain= s the motivation: avoiding name collisions and making the layer of each typ= e clear. Several references also switch to `Self::Command::` which is a nice improve= ment since it avoids repeating the type path: ```rust - GspSetSystemInfo::init(self.pdev) + Self::Command::init(self.pdev) ``` No issues. Mechanical and correct. --- --- Generated by Claude Code Patch Reviewer