public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: serdev: add rust private data to serdev_device
Date: Tue, 28 Apr 2026 14:14:44 +1000	[thread overview]
Message-ID: <review-patch2-20260427-rust_serdev-v6-2-173798d5e1a3@posteo.de> (raw)
In-Reply-To: <20260427-rust_serdev-v6-2-173798d5e1a3@posteo.de>

Patch Review

Adds `void *rust_private_data` to `struct serdev_device` with a doc comment:

```c
 * @rust_private_data:	Private data for the rust abstraction. This should
 *			not be used by the C drivers.
```

**Design concern:** This adds a void pointer to a C struct solely for Rust's benefit. It's needed because `drvdata` is already used for the driver's own data (T), and the Rust abstraction layer needs a separate location for its internal `PrivateData` (a `Completion` + error flag for probe/receive synchronization). There's no compile-time enforcement preventing C drivers from touching this field.

**Minor:** The field is uninitialized in C (no `= NULL` in allocators). The Rust side sets it during probe before it's read anywhere, so this is fine in practice, but it might be worth considering whether the serdev core allocator (`serdev_device_alloc`) should zero-initialize it for safety. Actually, `kzalloc` is typically used, so it should be zeroed.

No blocking issues, but this design choice merits subsystem maintainer buy-in (and the cover letter appropriately asks Rob Herring about this).

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-28  4:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 18:05 [PATCH v6 0/4] rust: add basic serial device bus abstractions Markus Probst via B4 Relay
2026-04-27 18:05 ` [PATCH v6 1/4] rust: devres: return reference in `devres::register` Markus Probst via B4 Relay
2026-04-28  4:14   ` Claude review: " Claude Code Review Bot
2026-04-27 18:05 ` [PATCH v6 2/4] serdev: add rust private data to serdev_device Markus Probst via B4 Relay
2026-04-28  4:14   ` Claude Code Review Bot [this message]
2026-04-27 18:05 ` [PATCH v6 3/4] rust: add basic serial device bus abstractions Markus Probst via B4 Relay
2026-04-28  4:14   ` Claude review: " Claude Code Review Bot
2026-04-27 18:05 ` [PATCH v6 4/4] samples: rust: add Rust serial device bus sample device driver Markus Probst via B4 Relay
2026-04-28  4:14   ` Claude review: " Claude Code Review Bot
2026-04-28  4:14 ` Claude review: rust: add basic serial device bus abstractions Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-29 18:21 [PATCH v7 0/4] " Markus Probst via B4 Relay
2026-04-29 18:21 ` [PATCH v7 2/4] serdev: add rust private data to serdev_device Markus Probst via B4 Relay
2026-05-05  1:18   ` Claude review: " Claude Code Review Bot
2026-04-20 20:07 [PATCH v5 0/4] rust: add basic serial device bus abstractions Markus Probst
2026-04-20 20:07 ` [PATCH v5 2/4] serdev: add rust private data to serdev_device Markus Probst
2026-04-22 23:21   ` Claude review: " Claude Code Review Bot
2026-04-11 15:10 [PATCH v4 0/4] rust: add basic serial device bus abstractions Markus Probst via B4 Relay
2026-04-11 15:10 ` [PATCH v4 2/4] serdev: add rust private data to serdev_device Markus Probst via B4 Relay
2026-04-11 22:55   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260427-rust_serdev-v6-2-173798d5e1a3@posteo.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox