From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: visionox-rm69299: Move power_on/off into prepare/unprepare Date: Tue, 28 Apr 2026 14:33:55 +1000 Message-ID: In-Reply-To: <20260427-visionox-rm69299-enable-v1-2-fa7d62d26d87@sigxcpu.org> References: <20260427-visionox-rm69299-enable-v1-0-fa7d62d26d87@sigxcpu.org> <20260427-visionox-rm69299-enable-v1-2-fa7d62d26d87@sigxcpu.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review A clean simplification. After patch 1, `prepare` just called `power_on` and `unprepare` just called `power_off`, so inlining them is the right call. One minor reverse-christmas-tree nit in the new `prepare`: ```c static int visionox_rm69299_prepare(struct drm_panel *panel) { int ret; struct visionox_rm69299 *ctx = panel_to_ctx(panel); ``` Kernel convention puts longer declarations first. This should be: ```c struct visionox_rm69299 *ctx = panel_to_ctx(panel); int ret; ``` Also, the diff removes a blank line between the error check and the subsequent block comment: ```c if (ret < 0) return ret; /* * Reset sequence of visionox panel requires the panel to be ``` The original had a blank line separating those, which aided readability. Very minor. No functional issues. --- Generated by Claude Code Patch Reviewer