From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/mediatek: mtk_hdmi_v2: Fix non-static global variable Date: Tue, 05 May 2026 11:40:57 +1000 Message-ID: In-Reply-To: <20260429-mediatek-drm-fix-sparse-warnings-v1-2-d95c4d118b83@collabora.com> References: <20260429-mediatek-drm-fix-sparse-warnings-v1-0-d95c4d118b83@collabora.com> <20260429-mediatek-drm-fix-sparse-warnings-v1-2-d95c4d118b83@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review ```c -const char *const mtk_hdmi_v2_clk_names[MTK_HDMI_V2_CLK_COUNT] = { +static const char *const mtk_hdmi_v2_clk_names[MTK_HDMI_V2_CLK_COUNT] = { ``` Correct. `mtk_hdmi_v2_clk_names` is only referenced within `mtk_hdmi_v2.c` (at definition and at line 1436 in a struct initializer). Same Fixes tag as patch 1, which is correct since both were introduced in the same commit. Reported-by/Closes present. **Reviewed-by worthy. No issues.** --- Generated by Claude Code Patch Reviewer