From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: serdev: add rust private data to serdev_device Date: Tue, 05 May 2026 11:18:29 +1000 Message-ID: In-Reply-To: <20260429-rust_serdev-v7-2-0d89c791b5c8@posteo.de> References: <20260429-rust_serdev-v7-0-0d89c791b5c8@posteo.de> <20260429-rust_serdev-v7-2-0d89c791b5c8@posteo.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Summary:** Adds a `void *rust_private_data` field to `struct serdev_devic= e` for use by the Rust abstraction. ```c + * @rust_private_data: Private data for the rust abstraction. This should + * not be used by the C drivers. */ struct serdev_device { ... + void *rust_private_data; }; ``` This is a C-side change touching a core kernel structure. The field is need= ed because the Rust abstraction stores a `PrivateData` (with a `Completion`= for probe/receive synchronization) that must be accessible from the `recei= ve_buf` callback before drvdata is fully set up. This is the same pattern u= sed by other subsystems. **Minor:** The doc comment says "rust" lowercase =E2=80=94 kernel conventio= n in documentation tends to capitalize "Rust" (e.g., `Documentation/rust/`)= . Consider `@rust_private_data: Private data for the Rust abstraction.` This needs an Ack from the serdev maintainer (Rob Herring) since it modifie= s the core C struct. --- --- Generated by Claude Code Patch Reviewer