From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: scripts: modpost: increase buf_printf's buffer size Date: Tue, 05 May 2026 10:17:58 +1000 Message-ID: In-Reply-To: <20260430-nova-exports-v1-2-7ca31664e983@nvidia.com> References: <20260430-nova-exports-v1-0-7ca31664e983@nvidia.com> <20260430-nova-exports-v1-2-7ca31664e983@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Verdict: Acceptable, but the choice of 1024 is arbitrary.** ```c -#define SZ 500 +#define SZ 1024 ``` The change doubles the buffer. 500 was already arbitrary. 1024 is fine for = now, but as Rust symbol mangling is verbose, this could be exceeded again i= n the future. The commit message justifies it well =E2=80=94 modpost is use= rspace, so stack usage isn't a concern. Worth considering: would it be more robust to `malloc`/`realloc` or use `as= printf` instead of a fixed stack buffer? This would eliminate the truncatio= n problem entirely. That said, this is a minimal fix and the truncation det= ection in patch 1 would catch future overflow, so this is acceptable as-is. --- Generated by Claude Code Patch Reviewer