From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings/display: Add Solomon SSD16xx e-paper controller binding Date: Tue, 05 May 2026 10:10:10 +1000 Message-ID: In-Reply-To: <20260430183311.2978142-3-devarsht@ti.com> References: <20260430183311.2978142-1-devarsht@ti.com> <20260430183311.2978142-3-devarsht@ti.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Generally well-done binding. A few concerns: 1. **`rotation` property schema ordering:** The `$ref` to `types.yaml` should come before the `enum` constraint per dt-binding conventions: ```yaml + rotation: + enum: [0, 90, 180, 270] + description: + Display rotation in degrees counter clockwise (0,90,180,270) + $ref: /schemas/types.yaml#/definitions/uint32 ``` Consider using the standard `rotation` property from `display/panel/panel-common.yaml` if applicable, rather than defining a custom one. 2. **Missing `spi-max-frequency` in required:** The binding says the max is 20 MHz but doesn't require the property. The driver falls back to 1 MHz default, which is fine, but stating it explicitly would be cleaner. 3. The compatible is panel-level (`gooddisplay,gdey042t81`) rather than controller-level (`solomon,ssd1683`), which is correct for DT bindings since the panel is what's physically present. --- --- Generated by Claude Code Patch Reviewer